XFE Git
XFE Studio Git
Git 首页 全局搜索
XFE 主站 文档 NuGet

XFESpaceNinjaServer

A simple server for a small space ninja game

公开
关注 0 Fork 0 Star 0
返回提交历史

XFEstudio/XFESpaceNinjaServer

chore: don't use ? for leaderboardService parameters (#1551)

This means the argument can be omitted when we really mean that it can be undefined — but we still want it to be explicitly given. Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1551 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>

5149d0e3
Sainan <63328889+Sainan@users.noreply.github.com>
提交于

代码差异

2 个文件 +6 -5
Modified src/services/leaderboardService.ts +4 -4
@@ -8,7 +8,7 @@ export const submitLeaderboardScore = async (
8 8 ownerId: string,
9 9 displayName: string,
10 10 score: number,
11 guildId?: string
11 guildId: string | undefined
12 12 ): Promise<void> => {
13 13 let expiry: Date;
14 14 if (schedule == "daily") {
@@ -39,9 +39,9 @@ export const getLeaderboard = async (
39 39 leaderboard: string,
40 40 before: number,
41 41 after: number,
42 pivotId?: string,
43 guildId?: string,
44 guildTier?: number
42 pivotId: string | undefined,
43 guildId: string | undefined,
44 guildTier: number | undefined
45 45 ): Promise<ILeaderboardEntryClient[]> => {
46 46 const filter: { leaderboard: string; guildId?: string; guildTier?: number } = { leaderboard };
47 47 if (guildId) {
Modified src/services/statsService.ts +2 -1
@@ -378,7 +378,8 @@ export const updateStats = async (accountOwnerId: string, payload: IStatsUpdate)
378 378 category,
379 379 accountOwnerId,
380 380 payload.displayName,
381 data as number
381 data as number,
382 payload.guildId
382 383 );
383 384 break;
384 385